build: deprecate CamelCase function and add tests for snakeCase for symmetryutilities.py.#155
Open
stevenhua0320 wants to merge 1 commit intodiffpy:mainfrom
Open
Conversation
sbillinge
reviewed
Feb 19, 2026
Contributor
sbillinge
left a comment
sbillinge
left a comment
There was a problem hiding this comment.
Thanks for this work @stevenhua0320 . Please see the comments on the other PR and apply them here also.
We will have to merge main into this PR to get it to pass tests, but that can be done after the other one merges.
WHen you touch each of these functions, please give some thought to things like the name. THis is our chance to change the name a bit as well as simply removing the camel case, but we also like to upgrade functions when we touch them, so do things like using pathlib and other good naming practices etc.. This is the best way to keep code fresh....upgrade functions only when you work on them for some other reasons.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@sbillinge ready to review