Deprecate: Deprecate setResidualEquation and getResidualEquation in Fitcontribution

[cadenmyers13]

These are the final deprecation in FitContribution. Also I missed tagging a deprecated function in SimpleRecipe so I added it here. This slipped by because there are no direct tests for SimpleRecipe

[cadenmyers13]

@sbillinge ready for review

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 70.63%. Comparing base (7443c6a) to head (1a3aa78).
⚠️ Report is 7 commits behind head on v3.3.0.

Additional details and impacted files

@@            Coverage Diff             @@
##           v3.3.0     #156      +/-   ##
==========================================
+ Coverage   70.55%   70.63%   +0.07%     
==========================================
  Files          25       25              
  Lines        3597     3606       +9     
==========================================
+ Hits         2538     2547       +9     
  Misses       1059     1059              

Files with missing lines	Coverage Δ
tests/test_contribution.py	99.58% <100.00%> (+0.01%)	⬆️

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[sbillinge]

Thanks for this @cadenmyers13 I will merge.

As a general matter, whenever we touch code we want to improve it, and since we are moving in the direction of using pytest for everything, when you do write new tests it is a good idea to write them using pytest so we don't add to legacy unittest tests that we may have to fix in the future.....

[cadenmyers13]

@sbillinge okay got it. Will do moving forward. Thanks!

[sbillinge]

This general philosophy applies to any update. For example, we now use pathlib for all our path munging. We don't want to go back through all our code to make that fix since everything is working, but if you touch a function for some other reason (deprecating it), it is good practice to make any obvious updates just on that function. Pathlib, but also anything else you notice that brings it up to current group standards. Of course, if it starts to break it, let's think again.