DIP16 Draft: Transaction Scripts#153
DIP16 Draft: Transaction Scripts#153sblackshear wants to merge 2 commits intodiem:mainfrom sblackshear:tx_script_diff
Conversation
sblackshear
requested review from
bob-wilson,
meng-xu-cs,
runtian-zhou,
tnowacki,
tzakian,
vgao1996 and
wrwg
davidiw
left a comment
davidiw
left a comment
There was a problem hiding this comment.
overall seems pretty reasonable, I would love to see pointers to other docs, so that this DIP could be included in some developer guide or specification on an end-to-end process.
Not sure what the point of the changelog is?
| Both script functions and the single function in a transaction script bytecode file have the following restrictions. For a function` f<ability_params>(param_types): ret_types` : | ||
|
|
||
| * The `ret_types` list is empty (i.e., the function does not return a value) | ||
| * The `param_types` list begins with one or more `signer` types |
There was a problem hiding this comment.
can you point to signer types?
| module: ModuleId, | ||
| function: Identifier, | ||
| ty_args: Vec<TypeTag>, |
There was a problem hiding this comment.
are these defined anywhere? can we point to them?
There was a problem hiding this comment.
They are all defined in move-core-types. I'll add a note below.
| pub struct Script { | ||
| code: Vec<u8>, | ||
| ty_args: Vec<TypeTag>, | ||
| args: Vec<TransactionArgument>, |
There was a problem hiding this comment.
can you point to TransactionArgument?
Co-authored-by: David Wolinsky <isaac.wolinsky@gmail.com>
This is (I think, but am not sure) how we agreed to document which parts of a DIP apply to which versions of Diem. Here, it's a bit awkward because the DIP didn't exist before Diem v1, but it is describing both v1 and v2 features. Definitely open to a different way of conveying this information if we can all standardize on it. |
davidiw
left a comment
davidiw
left a comment
There was a problem hiding this comment.
add links and let's land this?
| ### Changing script functions | ||
|
|
||
| * The name and type signature of an existing script function will never be changed. | ||
| * The set of error codes that may be returned by a script function is included in the [developer documentation](https://github.com/diem/diem/blob/main/language/diem-framework/transaction_scripts/doc/transaction_script_documentation.md) for each script. The error codes returned by a script function may grow or shrink, but the meaning of a given error code will remain fixed. E.g.: |
3 participants
No description provided.