Fix for issue #27 "Could not enter raw REPL"#161
Open
ropg wants to merge 2 commits intodhylands:masterfrom
Open
Fix for issue #27 "Could not enter raw REPL"#161ropg wants to merge 2 commits intodhylands:masterfrom
ropg wants to merge 2 commits intodhylands:masterfrom
Conversation
Serial connections were running as a prolonged exception handler for socket.gaierror because the code first tries it as an ip-address. This led to confusing stack traces. This fix gives that error a pass and then continues.
Author
|
I added the necessary changes to README.rst and redid with push -f so it's still just the two commits... |
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two fixes, each in its own commit.
First off, all serial connections were made in the exception handler for
socket.gaierrorbecause the port was first tried as an ip-address/DNS name. I made that pass and then continue, which leads to far less confusing stack traces.Second, I introduce the command-line option
-s,--suppress-resetto both pyboard and rshell to fix issue ESP32 "Could not enter raw repl" #27 "Could not enter raw REPL". The rationale for doing it this way is in the issue, so I won't duplicate here.