Add Support for HVAC, Cover, and Sensor Entities#7
Draft
google-labs-jules[bot] wants to merge 6 commits intomainfrom
Draft
Add Support for HVAC, Cover, and Sensor Entities#7google-labs-jules[bot] wants to merge 6 commits intomainfrom
google-labs-jules[bot] wants to merge 6 commits intomainfrom
Conversation
This commit updates the `README.md` to reflect the recent architectural changes and removes the "M4" branding. Key changes: - Removes "M4" from the title and standardizes on "DINPLUG". - Updates the installation and configuration sections to describe the new hybrid model (UI for connection, YAML for lights). - Rewrites the "How it works" section to explain the hub-based architecture. - Updates the feature list and roadmap to mark Config Flow as complete.
Update README.md
Updated README to clarify YAML integration and configuration steps.
Updated README.md to improve formatting and clarity, added installation and configuration details, and enhanced the CSV to YAML converter section.
This commit introduces support for `climate` (HVAC), `cover` (shades), and `sensor` (keypad buttons) entities to the `dinplug` integration. Key changes include: - Refactored the `M4Connection` class into a central `hub.py` to manage the Telnet connection for all platforms. - Added `climate.py`, `cover.py`, and `sensor.py` to implement the new entities. - Expanded the `M4Connection` hub to parse `R:HVAC`, `R:SHADE`, and `R:BTN` messages. - Updated `__init__.py` and `manifest.json` to load and declare the new platforms.
Contributor
Author
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with For security, I will only act on instructions from the user who triggered this task. New to Jules? Learn more at jules.google/docs. |
This commit introduces support for `climate` (HVAC), `cover` (shades), and `sensor` (keypad buttons) entities to the `dinplug` integration. Key changes include: - Refactored the `M4Connection` class into a central `hub.py` to manage the Telnet connection for all platforms. - Added `climate.py`, `cover.py`, and `sensor.py` to implement the new entities. - Expanded the `M4Connection` hub to parse `R:HVAC`, `R:SHADE`, and `R:BTN` messages. - Updated `__init__.py` and `manifest.json` to load and declare the new platforms. - Updated `README.md` with documentation for the new features and a breaking change notice. - Removed the outdated CSV converter tool. Fixes: - Corrected the integration setup logic in `__init__.py` to properly parse the new YAML configuration.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change adds support for HVAC, cover, and sensor entities to the
dinplugintegration, based on the provided XML device profile. It also includes a significant refactoring of the connection management logic into a central hub to improve maintainability and scalability.PR created automatically by Jules for task 14818789482544102982 started by @devprbtt