Open
Conversation
Updated HVAC control interfaces to include TCP protocol and adjusted response time. Added audio and video media elements.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Description
_1) so the Savant UI slider and per-zone feedback work correctly.ThermostatAddress2to carry the actual deviceid, and leftThermostatAddressas the UI zone identifier (note: use1for the UI zone).ThermostatAddress2in theidfield while preserving optimistic updates andHasReceivedCommandbehavior.1.3and added notes documenting the two-address usage and the rationale.Testing
Codex Task