Support multiple thermostat IDs in Absolute Controls HVAC JSON profile#3
Open
Support multiple thermostat IDs in Absolute Controls HVAC JSON profile#3
Conversation
Updated HVAC JSON profile to version 1.1 with protocol changes and added media interfaces.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
_1suffixes in state center bindings which prevented UI setpoint feedback for thermostat IDs greater than1.Description
absolute/absolute controls_hvac_json.xmlto remove hard-coded_1suffixes fromstate_center_bindingvalues so bindings use the generic names (for exampleThermostatCurrentCoolPointinstead ofThermostatCurrentCoolPoint_1).1.2and updatedrpm_xml_versionto reflect the change and added a notes entry about removing hard-coded zone suffixes.ENV_HVACCONTROLLER_SOURCEimplementations and continue to accept an action argumentThermostatAddresswhich is inserted into the JSONidfield via theparameter_listfor per-thermostat commands.HasReceivedCommandbehavior for setpoint, mode, power and fan actions so UI/state center updates immediately on user actions.Testing
Codex Task