Skip to content

Demo passkey support#51

Closed
Edamijueda wants to merge 2 commits intodevondragon:mainfrom
Edamijueda:issue-#45
Closed

Demo passkey support#51
Edamijueda wants to merge 2 commits intodevondragon:mainfrom
Edamijueda:issue-#45

Conversation

@Edamijueda
Copy link
Contributor

PR for issue #45

@devondragon
Copy link
Owner

Hey @Edamijueda — thank you for this contribution! Your work on adding WebAuthn/Passkey support to the demo app was a great starting point and we really appreciate you taking the initiative on this.

We've been working on the WebAuthn support in parallel on the framework library side as well, and ended up building on your work with some additional changes:

  • Upgraded to the stable 4.2.0 framework release with built-in WebAuthn support
  • Replaced the JS prompt for renaming passkeys with a Bootstrap modal dialog
  • Added security hardening (event delegation instead of global scope, user-friendly error messages, safe date parsing, JSON-first error response handling)
  • Added production configuration with environment variable overrides
  • Added passkey documentation to the README

Since the branch diverged significantly, we've opened #55 which includes your original commits with Co-authored-by credit. We're going to close this PR in favor of that one.

Thanks again for the contribution — it helped us move faster on getting passkey support into the demo app!

@devondragon
Copy link
Owner

Closing in favor of #55 which builds on this work. Thank you for the contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants