Shaving some bytes with reduce#8
Open
robinvdvleuten wants to merge 1 commit intodevelopit:masterfrom
robinvdvleuten:master
Open
Shaving some bytes with reduce#8robinvdvleuten wants to merge 1 commit intodevelopit:masterfrom robinvdvleuten:master
robinvdvleuten wants to merge 1 commit intodevelopit:masterfrom
robinvdvleuten:master
Conversation
|
Unfortunately, after minification, using reduce is actually larger (using https://jscompress.com/ which uses UglifyJS 3 and Babili): original (119 bytes): with reduce (123 bytes): |
Owner
|
Thanks for the great explanation @kevlened! This also jives with my experience. Worth noting that performance is also at play here, and reduce() has fairly poor performance. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi there! By using an array reduce on the key, you'll can go even leaner with 124 bytes 💪