Open
Conversation
Huge thanks to @bwendt-mylo for writing this previously in developit#24
This should make dlv API-compatible with lodash.get
Owner
|
Hey @aarondancer! Thanks for opening the PR. Would you be able to provide some context on why square bracket notation is important for your use-case? |
|
I dare say it make's composing array like indices easier to reason about. Like "im indexing an array, as opposed to accessing a property"... but imo you may very just go |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I realize that this was already attempted in #24, but with a little extra work I was able to support the edge cases mentioned in the thread.
I tested these changes against the
lodash.gettests and it's mostly compatible. Thelodash.gettests failing all seem like uncommon edge-cases, so I've opted not to address them.The following tests from
lodash.getfail:This will also address #27
cc @developit @bwendt-mylo