chore: Upgrade vulnerable dependencies.#28
Conversation
📝 WalkthroughWalkthroughThis pull request updates package manifests and build config across the monorepo. The root package.json adds a parallel Pre-merge checks❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: ASSERTIVE Plan: Pro Disabled knowledge base sources:
⛔ Files ignored due to path filters (1)
📒 Files selected for processing (1)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
🔇 Additional comments (2)
Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: ASSERTIVE
Plan: Pro
Disabled knowledge base sources:
- Linear integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
⛔ Files ignored due to path filters (1)
yarn.lockis excluded by!**/yarn.lock,!**/*.lock
📒 Files selected for processing (4)
package.json(2 hunks)packages/server/package.json(1 hunks)packages/sqlint/package.json(1 hunks)packages/sqlint/src/cli/loadConfig.ts(1 hunks)
🧰 Additional context used
🧬 Code graph analysis (1)
packages/sqlint/src/cli/loadConfig.ts (1)
packages/sqlint/src/index.ts (1)
RawConfig(11-11)
🔇 Additional comments (4)
package.json (2)
30-30: LGTM!Consolidates test execution across packages.
117-133: LGTM!Pinning transitive dependencies addresses known vulnerabilities.
packages/sqlint/src/cli/loadConfig.ts (1)
126-126: LGTM!Correct migration for js-yaml v4, where
load()is safe by default.packages/sqlint/package.json (1)
38-38: LGTM!Runtime and type definitions aligned for js-yaml v4.
Also applies to: 43-43
92ab1f0 to
8d14e2f
Compare
There was a problem hiding this comment.
Actionable comments posted: 1
♻️ Duplicate comments (1)
packages/server/package.json (1)
44-44: Node.js engine requirement still missing.BigQuery v8.1.1 requires Node.js 18+. Add
"engines": { "node": ">=18.0.0" }to enforce this requirement.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: ASSERTIVE
Plan: Pro
Disabled knowledge base sources:
- Linear integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
⛔ Files ignored due to path filters (1)
yarn.lockis excluded by!**/yarn.lock,!**/*.lock
📒 Files selected for processing (5)
package.json(2 hunks)packages/server/package.json(1 hunks)packages/sqlint/package.json(1 hunks)packages/sqlint/src/cli/loadConfig.ts(1 hunks)tsconfig.json(1 hunks)
🧰 Additional context used
🧬 Code graph analysis (1)
packages/sqlint/src/cli/loadConfig.ts (1)
packages/sqlint/src/index.ts (1)
RawConfig(11-11)
🔇 Additional comments (4)
tsconfig.json (1)
15-15: Approve skipLibCheck for this upgrade.Adding
skipLibCheck: trueis reasonable for this multi-dependency upgrade to avoid type conflicts. Monitor for any runtime issues that might surface from bypassed type checks.package.json (1)
30-30: LGTM on parallel test execution.The new test script efficiently runs all package tests in parallel.
packages/sqlint/package.json (1)
38-38: js-yaml v4 upgrade looks correct.Major version bump properly paired with type definitions and code migration (safeLoad → load in loadConfig.ts).
Also applies to: 43-43
packages/sqlint/src/cli/loadConfig.ts (1)
126-126: Correct js-yaml v4 migration.Replacing
safeLoadwithloadis the proper upgrade path. In v4,loadis safe by default.
8d14e2f to
0285569
Compare
Summary by CodeRabbit
Chores
Tests
✏️ Tip: You can customize this high-level summary in your review settings.