Fix comments breaking destructive UPDATE detection
#1532
+10
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
An inline comment could change the indexing of the tokens by introducing whitespace. The re.sub() fix is brutal but doesn't change the tokens. The fix also applies to extra whitespace without comments, which alone could also break the query_is_single_table_update() detection.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
An inline comment could change the indexing of the tokens by introducing whitespace. The
re.sub()fix is brutal but doesn't change the tokens.The fix also applies to extra whitespace without comments, which alone could also break the
query_is_single_table_update()detection.Checklist
changelog.mdfile.AUTHORSfile (or it's already there).