fix: check is_available() before creating Syphon output sink (#692)#694
Open
livepeer-tessa wants to merge 1 commit intomainfrom
Open
fix: check is_available() before creating Syphon output sink (#692)#694livepeer-tessa wants to merge 1 commit intomainfrom
livepeer-tessa wants to merge 1 commit intomainfrom
Conversation
On Linux/fal.ai workers, syphon-python is not installed (macOS only). Without an is_available() guard in _update_output_sink(), the frame processor tried to instantiate SyphonOutputSink and logged four ERROR lines per connection attempt, flooding the log with noise. - Add is_available() guard in frame_processor._update_output_sink(), mirroring the existing guard in _set_input_source() (added in #644/NDI) - Downgrade ImportError log level from ERROR to WARNING in: - scope.core.inputs.syphon.SyphonInputSource.connect() - scope.core.outputs.syphon.SyphonOutputSink.create() - scope.server.syphon.sender.SyphonSender.create() These paths are already gated by is_available() but the ImportError branch is still reachable in edge cases; ERROR is inappropriate for an expected platform-unavailability condition. Fixes #692 Related: #688 (SpoutGL), #644 (NDI) Signed-off-by: livepeer-robot <robot@livepeer.org>
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
📝 Coding Plan
Comment |
Contributor
🚀 fal.ai Preview Deployment
TestingConnect to this preview deployment by running this on your branch: 🧪 E2E tests will run automatically against this deployment. |
Contributor
✅ E2E Tests passed
Test ArtifactsCheck the workflow run for screenshots. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds the missing
is_available()guard for the Syphon output sink in_update_output_sink(), matching the existing guard already in place for input sources (added in #644/NDI).On fal.ai Linux workers,
syphon-pythonis not installed. Without the guard, every connection attempt from a user with a Syphon workflow saved from their Mac produced four ERROR log lines, flooding Grafana.Changes
frame_processor._update_output_sink()— addsink_class.is_available()check before instantiating the sink, identical pattern to the input source guard at line 827SyphonOutputSink.create()— downgradeImportErrorlog fromERROR→WARNING(macOS-only unavailability is expected, not an error)SyphonSender.create()— same downgradeSyphonInputSource.connect()— same downgrade (already gated byis_available()but ImportError path still reachable in edge cases)Related