Use FUSE for bundle commands on serverless#4450
Open
shreyas-goenka wants to merge 2 commits intomainfrom
Open
Conversation
shreyas-goenka
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
Collaborator
|
Commit: 92c796c
24 interesting tests: 9 RECOVERED, 7 flaky, 5 SKIP, 3 KNOWN
Top 50 slowest tests (at least 2 minutes):
|
shreyas-goenka
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
shreyas-goenka
requested review from
andrewnester,
anton-107,
denik and
pietern
as code owners
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
This PR updates the CLI to use the FUSE to read and write notebooks instead of the workspace APIs, when the DBR version is serverless 2.5+. This has the following benefits:
bundle generate --bindwhich were previously failing on DABs in the workspace due to both the workspace APIs and FUSE being used simultaneously.Tests
Manually verified that both bundle deploy / bundle generate continue to work correctly on DBR. Also verified that
bundle generate --bindworks on DBR.Acceptance tests will be added once #4416 lands.
bundle generate --bind works, i.e. all notebooks are written successfully via FUSE:
bundle deploy works, for all sorts of notebooks, i.e. they are read correctly.
This was tested and run on serverless
client.2.5(standard v2). The UI does not allow me to select a minor version so I could not test other client.2 versions like 2.4. That's why we only use FUSE from 2.5 onwards.In practice this is fine because customers wil also likely be using
2.5or above it they are on serverless.