CloudSql PostegreSql e2e test scenarios#200
Open
sawantpritam wants to merge 5 commits intodata-integrations:developfrom
Open
CloudSql PostegreSql e2e test scenarios#200sawantpritam wants to merge 5 commits intodata-integrations:developfrom
sawantpritam wants to merge 5 commits intodata-integrations:developfrom
Conversation
cloudSqlPSQL related test scenarios
rmstar
reviewed
Jan 6, 2022
Contributor
rmstar
left a comment
rmstar
left a comment
There was a problem hiding this comment.
We should have separate tests for source and sink plugins
| @@ -0,0 +1,103 @@ | |||
| <?xml version="1.0" encoding="UTF-8"?> | |||
| <!-- | |||
| Copyright © 2015-2019 Cask Data, Inc. | |||
| @@ -0,0 +1,45 @@ | |||
| Feature: CloudSQLPostgreSQL Sink and Error Validation | |||
Contributor
There was a problem hiding this comment.
Capitalize first letter in filename - cloudSql -> CloudSql
| @Then("Enter the CloudSQLPostgreSQL Source Properties with blank property {string}") | ||
| public void enterTheCloudSQLPostgreSQLSourcePropertiesWithBlankProperty(String property) throws IOException, | ||
| InterruptedException { | ||
| if (property.equalsIgnoreCase("referenceName")) { |
| } | ||
|
|
||
| @Then("Verify error is displayed for incorrect Connection Name with private instance type") | ||
| public void verifyTheCldMySqlInvalidPrivate() throws InterruptedException { |
| @Then("Enter the CloudSQLPostgreSQL Sink Properties with blank property {string}") | ||
| public void enterTheCloudSQLPostgreSQLSinkPropertiesWithBlankProperty(String property) throws IOException, | ||
| InterruptedException { | ||
| if (property.equalsIgnoreCase("referenceName")) { |
| } | ||
|
|
||
| @Then("Enter Connection Name with private instance type") | ||
| public void enterTheInvalidPrivate() throws InterruptedException, IOException { |
Contributor
There was a problem hiding this comment.
where is this used? also, please rename to something more meaningful
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@tivv @rmstar @itsankit-google Please review.