Ceil function is now used when calculating the item size#282
Open
Morerice wants to merge 1 commit intodarsain:masterfrom
Morerice:incorrect-width
Open
Ceil function is now used when calculating the item size#282Morerice wants to merge 1 commit intodarsain:masterfrom Morerice:incorrect-width
Morerice wants to merge 1 commit intodarsain:masterfrom
Morerice:incorrect-width
Conversation
|
Perfect, thank you ! You saved my day. Merge this fix please :-) |
|
I was looking into this issue and tried your modifications. They resolve the issue of not leaving enough space for the last item in my scenario, however, now there is too much space left. Either way, using Instead, the the natural item size needs to be used to calculate the total size. Maybe then it’s helpful to ceil this result to the next integer value. Update: I get pretty good results when just leaving out |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request is related to this issue: #200
The problem occurs because the round function is used to calculate the item width. Hence, if the width of an item is 10.3px it will be rounded to 10 and therefore, the calculated width of the frame won't be enough to contain the items.
This is shown here: https://jsfiddle.net/0cvejr3o/
In my pull request, I simply used the ceil function to calculate the width of each item.