Conversation
…olicy Signed-off-by: Cassandra Coyle <cassie@diagrid.io>
| ## Resiliency and redelivery | ||
|
|
||
| The Redis Streams pubsub component honors the [Dapr resiliency policy]({{% ref "resiliency-overview" %}}). After your | ||
| application handler returns (success, error, RETRY, or DROP), the component acknowledges the message to Redis. Redis |
There was a problem hiding this comment.
Any reason some are CAPITALs and others are not?
There was a problem hiding this comment.
I put RETRY and DROP capital bc they are explicit API status values from the PubSub API - see here: under the section titled Expected HTTP Response. I missed SUCCESS tho. I can update success to be capital for consistency, or I can lower then all if that is preferred. I used error as a general outcome rather than the status value.
| The Redis Streams pubsub component honors the [Dapr resiliency policy]({{% ref "resiliency-overview" %}}). After your | ||
| application handler returns (success, error, RETRY, or DROP), the component acknowledges the message to Redis. Redis | ||
| then stops redelivering that message. Retries and dead-letter behavior are controlled by your resiliency policy (for | ||
| example, `maxRetries` and retry duration), not by Redis indefinitely. |
There was a problem hiding this comment.
what does "not by Redis indefinitely" mean? Not sure what this is implying. Can you clarify
There was a problem hiding this comment.
Before my code PR, when the handler returned an error or RETRY, the component did not ACK the msg to Redis and it was redelivered indefinitely regardless of the resiliency policy. Now, the component ACKs and honors the resiliency policy and does not redeliver indefinitely. I thought it was important to note that explicitly bc its a bug fix & change in behavior.
There was a problem hiding this comment.
Ill just rm the last part of the sentence. this: not by Redis indefinitely. bc it will be implied bc it will follow the resiliency policy, then I think itll be good as-is.
daprdocs/content/en/reference/components-reference/supported-pubsub/setup-redis-pubsub.md
Outdated
Show resolved
Hide resolved
daprdocs/content/en/reference/components-reference/supported-pubsub/setup-redis-pubsub.md
Outdated
Show resolved
Hide resolved
update based on feedback Signed-off-by: Cassie Coyle <cassie.i.coyle@gmail.com>
3 participants
docs for this PR noting how we honor resiliency policy now and not redis infinite redelivery