Added docs for workflow versioning#5003
Conversation
...cs/content/en/developing-applications/building-blocks/workflow/workflow-features-concepts.md
Outdated
Show resolved
Hide resolved
...cs/content/en/developing-applications/building-blocks/workflow/workflow-features-concepts.md
Outdated
Show resolved
Hide resolved
...cs/content/en/developing-applications/building-blocks/workflow/workflow-features-concepts.md
Outdated
Show resolved
Hide resolved
...cs/content/en/developing-applications/building-blocks/workflow/workflow-features-concepts.md
Outdated
Show resolved
Hide resolved
Signed-off-by: Albert Callarisa <albert@diagrid.io>
Signed-off-by: Albert Callarisa <albert@diagrid.io>
Signed-off-by: Albert Callarisa <albert@diagrid.io>
9f73980 to
c07c0bf
Compare
WhitWaldo
left a comment
There was a problem hiding this comment.
I've got a few comments (mostly suggestion for rephrasing) as well
...cs/content/en/developing-applications/building-blocks/workflow/workflow-features-concepts.md
Outdated
Show resolved
Hide resolved
...cs/content/en/developing-applications/building-blocks/workflow/workflow-features-concepts.md
Outdated
Show resolved
Hide resolved
...cs/content/en/developing-applications/building-blocks/workflow/workflow-features-concepts.md
Outdated
Show resolved
Hide resolved
...cs/content/en/developing-applications/building-blocks/workflow/workflow-features-concepts.md
Outdated
Show resolved
Hide resolved
...cs/content/en/developing-applications/building-blocks/workflow/workflow-features-concepts.md
Outdated
Show resolved
Hide resolved
...cs/content/en/developing-applications/building-blocks/workflow/workflow-features-concepts.md
Outdated
Show resolved
Hide resolved
...cs/content/en/developing-applications/building-blocks/workflow/workflow-features-concepts.md
Outdated
Show resolved
Hide resolved
...cs/content/en/developing-applications/building-blocks/workflow/workflow-features-concepts.md
Outdated
Show resolved
Hide resolved
...cs/content/en/developing-applications/building-blocks/workflow/workflow-features-concepts.md
Outdated
Show resolved
Hide resolved
...cs/content/en/developing-applications/building-blocks/workflow/workflow-features-concepts.md
Outdated
Show resolved
Hide resolved
Signed-off-by: Albert Callarisa <albert@diagrid.io>
Signed-off-by: Albert Callarisa <albert@diagrid.io>
...cs/content/en/developing-applications/building-blocks/workflow/workflow-features-concepts.md
Outdated
Show resolved
Hide resolved
...cs/content/en/developing-applications/building-blocks/workflow/workflow-features-concepts.md
Outdated
Show resolved
Hide resolved
...cs/content/en/developing-applications/building-blocks/workflow/workflow-features-concepts.md
Outdated
Show resolved
Hide resolved
Signed-off-by: Albert Callarisa <albert@diagrid.io>
Signed-off-by: Albert Callarisa <albert@diagrid.io>
Signed-off-by: Albert Callarisa <albert@diagrid.io>
...cs/content/en/developing-applications/building-blocks/workflow/workflow-features-concepts.md
Outdated
Show resolved
Hide resolved
...cs/content/en/developing-applications/building-blocks/workflow/workflow-features-concepts.md
Outdated
Show resolved
Hide resolved
...cs/content/en/developing-applications/building-blocks/workflow/workflow-features-concepts.md
Outdated
Show resolved
Hide resolved
Signed-off-by: Albert Callarisa <albert@diagrid.io>
...cs/content/en/developing-applications/building-blocks/workflow/workflow-features-concepts.md
Outdated
Show resolved
Hide resolved
...cs/content/en/developing-applications/building-blocks/workflow/workflow-features-concepts.md
Outdated
Show resolved
Hide resolved
...cs/content/en/developing-applications/building-blocks/workflow/workflow-features-concepts.md
Outdated
Show resolved
Hide resolved
...cs/content/en/developing-applications/building-blocks/workflow/workflow-features-concepts.md
Outdated
Show resolved
Hide resolved
...cs/content/en/developing-applications/building-blocks/workflow/workflow-features-concepts.md
Outdated
Show resolved
Hide resolved
...cs/content/en/developing-applications/building-blocks/workflow/workflow-features-concepts.md
Outdated
Show resolved
Hide resolved
...cs/content/en/developing-applications/building-blocks/workflow/workflow-features-concepts.md
Outdated
Show resolved
Hide resolved
...cs/content/en/developing-applications/building-blocks/workflow/workflow-features-concepts.md
Outdated
Show resolved
Hide resolved
...cs/content/en/developing-applications/building-blocks/workflow/workflow-features-concepts.md
Outdated
Show resolved
Hide resolved
...cs/content/en/developing-applications/building-blocks/workflow/workflow-features-concepts.md
Outdated
Show resolved
Hide resolved
Signed-off-by: Albert Callarisa <albert@diagrid.io>
- Reflect consistent naming: "patching" vs "named workflows" - Reorder to put patching first and describe the documentation from the intended versioning approach as a whole (patch, named version to clean and refactor, loop). - Clarify that the two are meant to be complementary and are compatible with one another - Add .NET examples for patching and named workflows - Modify named section to reflect that .NET takes a slightly different approach (and can't support like-named workflows). Signed-off-by: Whit Waldo <whit.waldo@innovian.net>
Signed-off-by: Whit Waldo <whit.waldo@innovian.net>
Updated workflow versioning section
…rkflow/workflow-features-concepts.md Co-authored-by: Marc Duiker <marcduiker@users.noreply.github.com> Signed-off-by: Whit Waldo <whit.waldo@innovian.net>
Signed-off-by: Albert Callarisa <albert@diagrid.io>
msfussell
left a comment
There was a problem hiding this comment.
The Versioning section to be put into a separate document and not into the features-concept. There needs to be a short overview features-concept topic and this then linked to a separate article.
...cs/content/en/developing-applications/building-blocks/workflow/workflow-features-concepts.md
Outdated
Show resolved
Hide resolved
…T example, added link to .NET versioning SDK documentation, fixed link to Dapr CLI workflow reference. Added blurb to features-concepts to point to dedicated page. Signed-off-by: Whit Waldo <whit.waldo@innovian.net>
As soon as @acroca can give me push access on his fork again, I've got a pending PR locally that does this and fixes a few links. |
|
@acroca - Please can you enable @WhitWaldo access to your PR? |
|
Done right now |
|
@acroca Could you please merge https://github.com/acroca/dapr-docs/tree/whit-versioning-2 into your PR? |
|
Done |
msfussell
left a comment
There was a problem hiding this comment.
A few simply comments to fix
...cs/content/en/developing-applications/building-blocks/workflow/workflow-features-concepts.md
Outdated
Show resolved
Hide resolved
...cs/content/en/developing-applications/building-blocks/workflow/workflow-features-concepts.md
Outdated
Show resolved
Hide resolved
...cs/content/en/developing-applications/building-blocks/workflow/workflow-features-concepts.md
Outdated
Show resolved
Hide resolved
...cs/content/en/developing-applications/building-blocks/workflow/workflow-features-concepts.md
Outdated
Show resolved
Hide resolved
daprdocs/content/en/developing-applications/building-blocks/workflow/workflow-versioning.md
Outdated
Show resolved
Hide resolved
daprdocs/content/en/developing-applications/building-blocks/workflow/workflow-versioning.md
Outdated
Show resolved
Hide resolved
daprdocs/content/en/developing-applications/building-blocks/workflow/workflow-versioning.md
Outdated
Show resolved
Hide resolved
daprdocs/content/en/developing-applications/building-blocks/workflow/workflow-versioning.md
Outdated
Show resolved
Hide resolved
daprdocs/content/en/developing-applications/building-blocks/workflow/workflow-versioning.md
Outdated
Show resolved
Hide resolved
...cs/content/en/developing-applications/building-blocks/workflow/workflow-features-concepts.md
Show resolved
Hide resolved
|
@acroca - PTAL |
…rkflow/workflow-features-concepts.md Co-authored-by: Mark Fussell <markfussell@gmail.com> Signed-off-by: Whit Waldo <whit.waldo@innovian.net>
…rkflow/workflow-features-concepts.md Co-authored-by: Mark Fussell <markfussell@gmail.com> Signed-off-by: Whit Waldo <whit.waldo@innovian.net>
…rkflow/workflow-features-concepts.md Co-authored-by: Mark Fussell <markfussell@gmail.com> Signed-off-by: Whit Waldo <whit.waldo@innovian.net>
…rkflow/workflow-features-concepts.md Co-authored-by: Mark Fussell <markfussell@gmail.com> Signed-off-by: Whit Waldo <whit.waldo@innovian.net>
…rkflow/workflow-versioning.md Co-authored-by: Mark Fussell <markfussell@gmail.com> Signed-off-by: Whit Waldo <whit.waldo@innovian.net>
…rkflow/workflow-versioning.md Co-authored-by: Mark Fussell <markfussell@gmail.com> Signed-off-by: Whit Waldo <whit.waldo@innovian.net>
…rkflow/workflow-versioning.md Co-authored-by: Mark Fussell <markfussell@gmail.com> Signed-off-by: Whit Waldo <whit.waldo@innovian.net>
…rkflow/workflow-versioning.md Co-authored-by: Mark Fussell <markfussell@gmail.com> Signed-off-by: Whit Waldo <whit.waldo@innovian.net>
…rkflow/workflow-versioning.md Co-authored-by: Mark Fussell <markfussell@gmail.com> Signed-off-by: Whit Waldo <whit.waldo@innovian.net>
|
|
||
| {{< /tabpane >}} | ||
|
|
||
| ### Versioning Process Guidance |
There was a problem hiding this comment.
I would either put a link to this section on guidance from the ## Versioning overview, or move this into the [workflow/workflow-versioning.md] document at the start. It seems odd to keep this on the concepts section otherwise.
At the moment I just added the Go code, as it's the only SDK that supports it. We'll need to add more code examples as we add support.