Conversation
Signed-off-by: Oksana Salyk <oksana.salyk@hpe.com> update after review Signed-off-by: Oksana Salyk <oksana.salyk@hpe.com> test: add another batch of fixes Signed-off-by: Oksana Salyk <oksana.salyk@hpe.com> improve the next tests Signed-off-by: Oksana Salyk <oksana.salyk@hpe.com>
Signed-off-by: Oksana Salyk <oksana.salyk@hpe.com> add gradlew configuration Signed-off-by: Oksana Salyk <oksana.salyk@hpe.com> add corrections after review Signed-off-by: Oksana Salyk <oksana.salyk@hpe.com> fix stage name Signed-off-by: Oksana Salyk <oksana.salyk@hpe.com> fix stage name Signed-off-by: Oksana Salyk <oksana.salyk@hpe.com> Skip-daos-build-and-test: true
Skip-daos-build-and-test: true Signed-off-by: Oksana Salyk <oksana.salyk@hpe.com>
Signed-off-by: Oksana Salyk <oksana.salyk@hpe.com>
osalyk
force-pushed
the
osalyk/pipline-lib_tests
branch
from
8fcad29 to
7b03f25
Compare
Skip-daos-build-and-test: true Signed-off-by: Oksana Salyk <oksana.salyk@hpe.com>
osalyk
force-pushed
the
osalyk/pipline-lib_tests
branch
from
7b03f25 to
3846224
Compare
Skip-daos-build-and-test: true Signed-off-by: Oksana Salyk <oksana.salyk@hpe.com>
Skip-daos-build-and-test: true Signed-off-by: Oksana Salyk <oksana.salyk@hpe.com>
Skip-daos-build-and-test: true Signed-off-by: Oksana Salyk <oksana.salyk@hpe.com>
osalyk
force-pushed
the
osalyk/pipline-lib_tests
branch
from
cad8cc5 to
7dd9560
Compare
Signed-off-by: Oksana Salyk <oksana.salyk@hpe.com>
Skip-daos-build-and-test: true Signed-off-by: Oksana Salyk <oksana.salyk@hpe.com>
Skip-daos-build-and-test: true Signed-off-by: Oksana Salyk <oksana.salyk@hpe.com>
JohnMalmberg
left a comment
JohnMalmberg
left a comment
There was a problem hiding this comment.
This code does not appear to be able to pass groovylint checks.
Every "def" declaration is going to cause Jenkins log noise. There are a few cases where it must be used for some function return values, and in those cases it should be suppressed, in all others it should be the proper type.
The groovylint for visual studio code can not detect if the first use of a variable is missing a type declaration, which is serious for Jenkins as can cause intermittent data corruption.
The current system-pipeline-lib PR I have open has code to doing the groovylint, that also checks for undeclared variables both runnable as a github action and as a pre-commit hook.
Jenkinsfile
Outdated
| parallel { | ||
| stage('JUnit Tests') { | ||
| agent { | ||
| label 'brd-108_light_1' |
There was a problem hiding this comment.
We never want a named build agent host as a target label for a PR intended for landing.
|
@JohnMalmberg wrote:
That's great! When it got landed in the system-pipeline-lib we can adopt it here and forget about this kind of issues in the future. 🙂 Ref: https://github.com/daos-stack/system-pipeline-lib/pull/18 |
Signed-off-by: Oksana Salyk <oksana.salyk@hpe.com>
3 participants
No description provided.