Merged
Conversation
Enable automatic PR preview builds via Netlify while keeping GitHub Pages as the production deployment for docs.dandiarchive.org. Closes #119 Co-Authored-By: Claude Code 2.1.92 / Claude Opus 4.6 <noreply@anthropic.com>
Member
Author
|
may be I do need to merge first... no harm should be so I will proceed |
Member
Author
|
I manually triggered build and we got https://dandi-docs.netlify.app/ ... let's see if PRs rebased now would get their previews |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add Netlify configuration for automatic PR preview deployments, resolving the long-standing request in #119.
docs.dandiarchive.org) — no changes therenetlify.tomlSetup required (one-time, Netlify dashboard)
Connect Netlify before merging so this PR itself serves as the test:
dandiorg (if not already done)dandi/dandi-docsrepositorynetlify.tomlfrom the PR branch — click "Deploy site"docs.dandiarchive.org) in Netlify — that stays on GitHub Pagesdandi-docs) in Site configuration → Site details → Change site nameNetlify will immediately pick up this open PR and post a preview link, confirming everything works before merge.
After this, every future PR will automatically get:
https://deploy-preview-42--dandi-docs.netlify.app)Test plan
netlify.tomlbuild command works:pip install -r requirements.txt && mkdocs buildCloses #119
🤖 Generated with Claude Code