Open
Conversation
8e10873 to
86a8acd
Compare
86a8acd to
413d65a
Compare
413d65a to
26cd5e3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
these changes are around unifying argument count and type validation errors:
many functions are of the format:
here I am proposing following a different pattern:
CheckStrictArgsis one of several functions that allow for a range of flexible argument type checking. The general idea is the call to them takes the function and the type names of the arguments and it will do the argument count and type checking for you, returning the same error values as previously, only the argument number error has more info.My apologies for wasting time if this isn't in the scope of the project. I was only intending on adding in a http client module to the standard library but I couldn't help but find the manual error checking of the
args ...Objectvery repatitve boilerplate code and not DRY.