added processing of URL as template#87
Open
dcmartin wants to merge 2 commits intocustom-components:masterfrom
Open
added processing of URL as template#87dcmartin wants to merge 2 commits intocustom-components:masterfrom
dcmartin wants to merge 2 commits intocustom-components:masterfrom
Conversation
Author
|
Forgot to import configuration validation. Now fixed. |
Collaborator
|
@dcmartin thank you for your contribution. Could you please address the CI failures? I understand the concept, but could you put an example config that you tested your patch with? I would say that this functionality should be covered by tests. I can add them once you share the sensor config. |
Collaborator
|
@dcmartin Do you plan to work on this PR and resolve the conflicts? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I updated the processing of the specified URL to be a template. Has been working for me flawlessly with previous version.