added tests for timezone offset tests#88
Open
bryantaustin13 wants to merge 1 commit intocqframework:mainfrom
Open
added tests for timezone offset tests#88bryantaustin13 wants to merge 1 commit intocqframework:mainfrom
bryantaustin13 wants to merge 1 commit intocqframework:mainfrom
Conversation
raleigh-g-thompson
requested changes
Mar 10, 2026
Contributor
raleigh-g-thompson
left a comment
raleigh-g-thompson
left a comment
There was a problem hiding this comment.
- Incorrect outputs on the three "NullWhen..." tests in the "No default offset" group — shouldn't these be null rather than true?
- Missing version attribute — why is there no version attribute on the Policy: Default to server offset (normalize offset-less to server) group?
- {{SERVER_OFFSET_ISO}} placeholder — could you add a comment explaining the runtime substitution mechanism to help future maintainers?
- New capability codes — are timezone-offset-policy.no-default-offset and timezone-offset-policy.default-server-offset documented somewhere, or is that planned as a follow-up?
| <test name="DateTimeEquality_DefaultServerOffset_EqualsWhenExplicitServerOffsetGiven" version="1.5"> | ||
| <capability code="timezone-offset"/> | ||
| <capability code="timezone-offset-policy.default-server-offset"/> | ||
| <expression>@2012-04-01T00:00 = @2012-04-01T00:00{{SERVER_OFFSET_ISO}}</expression> |
Contributor
There was a problem hiding this comment.
Can we include a comment that describes how to use {{SERVER_OFFSET_ISO}}?
Is there documentation describing timezone-offset capabilities?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
uses codes from HL7/cql#103 (comment)
Answers this issue
#81 -- Timezoneoffset policy tests