Add GNOME Shell 50 support and harden sensor/menu compatibility#528
Open
NicksLameCode wants to merge 1 commit intocorecoding:developfrom
Open
Add GNOME Shell 50 support and harden sensor/menu compatibility#528NicksLameCode wants to merge 1 commit intocorecoding:developfrom
NicksLameCode wants to merge 1 commit intocorecoding:developfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This updates Vitals for GNOME Shell 50 and hardens several fragile runtime paths without broad refactoring.
Changes
"50"toshell-versioninmetadata.json.actorassumptions with compatibility helpers inextension.js_closeMenu()helpermenuItem.jsto work with both direct actors and actor-backed itemssensors.jsto avoid propagatingundefined,NaN, orInfinityvalues.jsWhy
GNOME 50 itself did not require a major rewrite here, but Vitals was blocked by:
"50"in extension metadataThese changes keep the patch small and aim to preserve compatibility with GNOME 45–49.
Validation
git diff --checkglib-compile-schemas --strict schemas/metadata.jsoncontains"50"dbus-run-session -- gnome-shell --devkit --waylandcompleted without Vitals-specific JS errorsNotes
This PR targets
develop.Private panel placement logic was intentionally left unchanged because it was not the GNOME 50 blocker.