topology-aware: Add unit tests for resources#656
Open
ozhuraki wants to merge 1 commit intocontainers:mainfrom
Open
topology-aware: Add unit tests for resources#656ozhuraki wants to merge 1 commit intocontainers:mainfrom
ozhuraki wants to merge 1 commit intocontainers:mainfrom
Conversation
Collaborator
|
@ozhuraki For the topology-aware policy, we should be careful with adding unit tests that exercise internal interfaces, as they inevitably add (even) more (than the currently existing) inertia against changes... including cleanups. And especially these bits in the topology-aware policy will probably need to be touched in the near future, so I think it probably would be better to hold back unit tests until after such changes have landed. |
Signed-off-by: Oleg Zhurakivskyy <oleg.zhurakivskyy@intel.com>
Contributor
Author
OK, thanks. I have reworked to use only exported interfaces, PTAL. If yet too intrusive, we could hold. |
klihub
reviewed
Apr 8, 2026
Contributor
Author
|
@klihub Thanks for the help! Updated, PTAL. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.