Skip to content

topology-aware: Add unit tests for resources#656

Open
ozhuraki wants to merge 1 commit intocontainers:mainfrom
ozhuraki:test-resources
Open

topology-aware: Add unit tests for resources#656
ozhuraki wants to merge 1 commit intocontainers:mainfrom
ozhuraki:test-resources

Conversation

@ozhuraki
Copy link
Copy Markdown
Contributor

@ozhuraki ozhuraki commented Apr 6, 2026

No description provided.

@klihub
Copy link
Copy Markdown
Collaborator

klihub commented Apr 7, 2026

@ozhuraki For the topology-aware policy, we should be careful with adding unit tests that exercise internal interfaces, as they inevitably add (even) more (than the currently existing) inertia against changes... including cleanups. And especially these bits in the topology-aware policy will probably need to be touched in the near future, so I think it probably would be better to hold back unit tests until after such changes have landed.

Signed-off-by: Oleg Zhurakivskyy <oleg.zhurakivskyy@intel.com>
@ozhuraki
Copy link
Copy Markdown
Contributor Author

ozhuraki commented Apr 7, 2026

@klihub

we should be careful with adding unit tests that exercise internal interfaces

OK, thanks. I have reworked to use only exported interfaces, PTAL. If yet too intrusive, we could hold.

@ozhuraki
Copy link
Copy Markdown
Contributor Author

ozhuraki commented Apr 8, 2026

@klihub Thanks for the help! Updated, PTAL.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants