Use the official moby/api types for Docker progress#750
Open
mtrmac wants to merge 1 commit intocontainers:mainfrom
Open
Use the official moby/api types for Docker progress#750mtrmac wants to merge 1 commit intocontainers:mainfrom
mtrmac wants to merge 1 commit intocontainers:mainfrom
Conversation
Nowadays the API type definitions are separate from code, and we indirectly import this subpackage anyway (it's used by moby/client, we can't avoid it), so use the official types instead of private copies. Should not change behavior against ordinary clients; hypothetically might cause decoding errors if one of the now-decoded fields used an invalid type or value. Signed-off-by: Miloslav Trmač <mitr@redhat.com>
Member
|
Do we want this? At least on the podman side I somewhat regret having to deal with the consistent breaking changes of the types, new names, deprecations, etc... I guess this is simple enough to not matter here so no strong opinion. I am fine with merging. |
Contributor
Author
|
I don’t feel strongly about this at all. This code is exposed to the Alternatively, we could just update the comments here to stop referring to removed subpackages. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A low-priority cleanup.
Nowadays the API type definitions are separate from code, and we indirectly import this subpackage anyway (it's used by
moby/client, we can't avoid it), so use the official types instead of private copies.Should not change behavior against ordinary clients; hypothetically might cause decoding errors if one of the now-decoded fields used an invalid type or value.