Closed
Conversation
Author
|
Closed in favor of #28. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Here is everything you need to know about this upgrade. Please take a good look at what changed and the test results before merging this pull request.
What changed?
✳️ rubocop (~> 0.76 → ~> 1.8) · Repo · Changelog
Release Notes
1.8.1
Does any of this look wrong? Please let us know.
Commits
See the full diff on Github. The new version differs by 17 commits:
Cut 1.8.1Update ChangelogFix bug not escape double quotes.[Fix #8281] Improve WhileUntilModifier detection and correction[Fix #9304] Do not register an offense for `Style/ExplicitBlockArgument` when the `yield` arguments are not an exact match with the block arguments.Merge pull request #9360 from dvandersluis/allow-pryMerge pull request #9361 from dvandersluis/issue/9355Add @dvandersluis to the Core Team[Fix #9355] Fix `Style/SingleLineMethods` autocorrection to endless method when the original code had parens.Allow `pry` to be activated in rspec if in the local gemfile.[Fix #8320] Replace Gitter with Discord[Fix #9350] Wrap in parens before replacing `unless` with `if` and `!`Add specs that demonstrate bug in Style/SoleNestedConditional[Fix #8229] Fix faulty calculation in UncommunicativeNameFix duplicate extension cop versions when `rubocop -V`[Fix #9342] Fix an error for `Lint/RedundantDirGlobSort`Switch back the docs version to masterDepfu will automatically keep this PR conflict-free, as long as you don't add any commits to this branch yourself. You can also trigger a rebase manually by commenting with
@depfu rebase.All Depfu comment commands