Reset startup when extractor is restarted

[toondaey]

This will ensure that a startup is reported when an extractor is (re)started. Orignally, this only reports a startup on extractor cold start.

[codecov]

Codecov Report

❌ Patch coverage is 66.66667% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 81.20%. Comparing base (7187ddd) to head (8a89ce2).

Files with missing lines	Patch %	Lines
cognite/extractorutils/unstable/core/runtime.py	0.00%	2 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##           master     #507      +/-   ##
==========================================
- Coverage   81.22%   81.20%   -0.03%     
==========================================
  Files          43       43              
  Lines        4208     4214       +6     
==========================================
+ Hits         3418     3422       +4     
- Misses        790      792       +2     

Files with missing lines	Coverage Δ
...ite/extractorutils/unstable/core/checkin_worker.py	91.04% <100.00%> (+0.18%)	⬆️
cognite/extractorutils/unstable/core/runtime.py	70.00% <0.00%> (-0.59%)	⬇️

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[gemini-code-assist]

Summary of Changes

Hello, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request enhances the extractor's lifecycle reporting by ensuring that startup events are accurately reported not just on initial launch, but also upon any subsequent restarts. This change provides a clearer and more consistent view of extractor operational status, which is crucial for monitoring and debugging. The update involves modifying the core checkin logic and integrating it with the runtime restart mechanism, along with comprehensive testing to confirm its reliability.

Highlights

• Startup Reporting Logic: Implemented a reset_startup method within the CheckinWorker to explicitly allow the extractor to re-report its startup status after a restart.
• Runtime Integration: Integrated the reset_startup call into the extractor's runtime, ensuring that a new startup report is triggered whenever the extractor restarts, for example, due to configuration changes.
• Test Coverage: Added a new test case, test_run_report_periodic_reset_startup, to thoroughly validate the functionality of resetting and re-reporting extractor startup events.
• Test Configuration Fix: Corrected the API endpoint URLs in the test configuration (conftest.py) by adding a missing forward slash, ensuring accurate mocking of startup and checkin requests.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Changelog

• cognite/extractorutils/unstable/core/checkin_worker.py
  • Added reset_startup method to allow re-reporting of extractor startup.
• cognite/extractorutils/unstable/core/runtime.py
  • Called checkin_worker.reset_startup() when a RuntimeMessage.RESTART is received.
• pyproject.toml
  • Added a [dependency-groups] section with an empty dev group.
• tests/test_unstable/conftest.py
  • Corrected API endpoint URLs for integrations/startup and integrations/checkin in test setup.
• tests/test_unstable/test_checkin_worker.py
  • Added test_run_report_periodic_reset_startup to verify the new startup reset functionality.

Ignored Files

• Ignored by pattern: .github/workflows/** (1)
  • .github/workflows/test_and_build.yml

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request introduces a mechanism to reset the startup status of an extractor, ensuring that a startup is reported again upon restart. The core logic change is sound, adding a reset_startup method to CheckinWorker and calling it from the runtime on a restart message. However, I've found a critical race condition in the new reset_startup method due to a missing lock. Additionally, the new test case meant to verify this functionality is flawed and will not work as intended due to issues with state management and token reuse. Please see my detailed comments for suggestions on how to fix these issues.