Skip to content

Init a basic server python#7

Merged
Lederain merged 5 commits intomainfrom
2-init-a-basic-server-python
Sep 25, 2025
Merged

Init a basic server python#7
Lederain merged 5 commits intomainfrom
2-init-a-basic-server-python

Conversation

@Lederain
Copy link
Collaborator

#2

@Lederain Lederain self-assigned this Sep 14, 2025
@Lederain Lederain added the enhancement New feature or request label Sep 14, 2025
@Lederain Lederain linked an issue Sep 14, 2025 that may be closed by this pull request
Copy link
Member

@guilhem-sante guilhem-sante left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you move your API source code to a python subdirectory? I fear it will conflict with @dfayd0's code otherwise.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To avoid triggering the GitHub Action for every PR you can set a on.pull_request.paths attribute as such (check here:

on:
  pull_request:
    paths:
      - 'servers/python/**'

And I would rename the file and the GitHub Action something like Market Server Python Linting. While Ruff gives me a good idea of what this Action does, it doesn't really tell me to which project this CI was defined for.

Finally, I don't know if the action is actually testing your application source code because I think you are running the commands at the repository root directory not at your server directory. If you want to you can use the official ruff github action it should make the process a bit more easy.

Copy link
Member

@dfayd0 dfayd0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

C’est tip top! Trop cool de review la team 👯‍♂️
juste petite correction au niveau du versionning, sinon go mettre ca sur main ASAP et taclé les prochaines issues.

@guilhem-sante guilhem-sante self-requested a review September 16, 2025 12:23
Copy link
Member

@guilhem-sante guilhem-sante left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Attention aux paths dans la CI qui sont erronés je crois.

Il faut bien move le serveur dans un subdir aussi.

@Lederain Lederain merged commit 609ec63 into main Sep 25, 2025
1 check passed
@Lederain Lederain deleted the 2-init-a-basic-server-python branch September 25, 2025 10:52
@guilhem-sante guilhem-sante added server Back end related issue python involving the python programming language labels Sep 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request python involving the python programming language server Back end related issue

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Init a basic server

3 participants