Conversation
guilhem-sante
left a comment
There was a problem hiding this comment.
Can you move your API source code to a python subdirectory? I fear it will conflict with @dfayd0's code otherwise.
There was a problem hiding this comment.
To avoid triggering the GitHub Action for every PR you can set a on.pull_request.paths attribute as such (check here:
on:
pull_request:
paths:
- 'servers/python/**'And I would rename the file and the GitHub Action something like Market Server Python Linting. While Ruff gives me a good idea of what this Action does, it doesn't really tell me to which project this CI was defined for.
Finally, I don't know if the action is actually testing your application source code because I think you are running the commands at the repository root directory not at your server directory. If you want to you can use the official ruff github action it should make the process a bit more easy.
dfayd0
left a comment
There was a problem hiding this comment.
C’est tip top! Trop cool de review la team 👯♂️
juste petite correction au niveau du versionning, sinon go mettre ca sur main ASAP et taclé les prochaines issues.
guilhem-sante
left a comment
There was a problem hiding this comment.
Attention aux paths dans la CI qui sont erronés je crois.
Il faut bien move le serveur dans un subdir aussi.
#2