-
Notifications
You must be signed in to change notification settings - Fork 434
Add VPN API smoke and unit tests; Test implementation support #4506
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Developer Guide build artifacts are available for download from this workflow run:
Developer Guide quality checks: |
✅ Continuous Quality ReportTest & Coverage
Static Analysis
Generated automatically by the PR CI workflow. |
Collaborator
Author
|
Compared 31 screenshots: 31 matched. Native Android coverage
✅ Native Android screenshot tests passed. Native Android coverage
|
Collaborator
Author
|
Compared 31 screenshots: 31 matched. Benchmark Results
Detailed Performance Metrics
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
NetworkManagerdelegation without relying on platform networking.Description
VPNDetectionAPITestthat callsNetworkManager.getInstance().isVPNDetectionSupported()andNetworkManager.getInstance().isVPNActive()and registered it inCn1ssDeviceRunner.vpnDelegatesToImplementation()inmaven/core-unittests/src/test/java/com/codename1/io/NetworkManagerTest.javathat verifiesNetworkManagerdelegates the VPN APIs to the implementation.TestCodenameOneImplementationwithvpnDetectionSupportedandvpnActivefields, asetVPNState(boolean, boolean)helper, and overrides forisVPNDetectionSupported()andisVPNActive()to allow deterministic testing.docs/developer-guide/io.asciidocupdates) so the APIs are implemented and documented across ports.Testing
cd maven && mvn -pl core-unittests -am -DunitTests=true -Dmaven.javadoc.skip=true -DfailIfNoTests=false -Dtest=NetworkManagerTest test, and the suite passed including the newvpnDelegatesToImplementationtest.cd scripts/hellocodenameone/common && mvn test -DskipTests=false, but it failed in this environment due to an unresolvedcom.codenameone:codenameone-maven-plugin:8.0-SNAPSHOTartifact (environment limitation).Codex Task