fix(core): resolve PHPStan iterable type errors (#8732)#9803
fix(core): resolve PHPStan iterable type errors (#8732)#9803Chucho-Kun wants to merge 1 commit intocodeigniter4:developfrom
Conversation
|
Hi there, Chucho-Kun! 👋 Thank you for sending this PR! We expect the following in all Pull Requests (PRs).
Important We expect all code changes or bug-fixes to be accompanied by one or more tests added to our test suite to prove the code works. If pull requests do not comply with the above, they will likely be closed. Since we are a team of volunteers, we don't have any more time to work See https://github.com/codeigniter4/CodeIgniter4/blob/develop/contributing/pull_request.md Sincerely, the mergeable bot 🤖 |
|
Thank you. Please omit any modifications related to |
07b45af to
e887557
Compare
|
For the BasicModel, I recently closed PR. We could not agree on the rules of phpDoc - phpstan or simple types. I stopped correcting the typing. |
|
👋 Hi, @Chucho-Kun! |
Description
PHPStan errors were eliminated by reducing the baseline to 1200 errors as part of my contribution to the good first issue label
The modifications is in the branch fix/issue-8732-basemodel-types and were validated with the following command