Refactor CMake with JRL CMake Modules v2#794
Draft
ahoarau wants to merge 74 commits intocoal-library:develfrom
Draft
Refactor CMake with JRL CMake Modules v2#794ahoarau wants to merge 74 commits intocoal-library:develfrom
ahoarau wants to merge 74 commits intocoal-library:develfrom
Conversation
ahoarau
force-pushed
the
jrl-next
branch
2 times, most recently
from
075411a to
e6124d7
Compare
ahoarau
force-pushed
the
jrl-next
branch
2 times, most recently
from
f08dcf7 to
db35568
Compare
new method with COMPONENTS
they are now generated by jrl v2
if we enable OCTOMAP, the library is REQUIRED. We are supposed to have it. testing is a library is available creates opacity in what we are actually building, better to enable+require, fatal_error otherwise
Boost.Test was included as a standalone library (included/unit_test.hpp), but linked against a shared_library Boost::unit_test_framework
…options via env vars
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is a full rewrite of the CMake files with the JRL CMake Modules v2.
c++17minimum requiredhpp-fcl-compatiblityis now aCOMPONENT