feat: make TARGETS optional so it can be overridden#116
Merged
cnlohr merged 1 commit intocnlohr:masterfrom Nov 18, 2025
Merged
Conversation
Contributor
Author
|
I am not that much familiar with make, so there is chances this is not needed at all and I just don't know how to do what I wanted 😅 |
Owner
|
No, if you potentially want to override it that's exactly how you do it. good job. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
Currently all architectures are built by default (a520051), but the way the TARGETS variable is defined, it doesn't allow it to be overridden by projects using this as a submodule, like rawdrawandroidexample does.
Trying to override the default targets wont work. Seems like it's just get concatenated with the default ones.
Solution
Make TARGETS optional so it can be overridden while keep the default value building all architectures by default.