Skip to content

feat: make TARGETS optional so it can be overridden#116

Merged
cnlohr merged 1 commit intocnlohr:masterfrom
DanielSRS:fix_targets
Nov 18, 2025
Merged

feat: make TARGETS optional so it can be overridden#116
cnlohr merged 1 commit intocnlohr:masterfrom
DanielSRS:fix_targets

Conversation

@DanielSRS
Copy link
Contributor

Issue

Currently all architectures are built by default (a520051), but the way the TARGETS variable is defined, it doesn't allow it to be overridden by projects using this as a submodule, like rawdrawandroidexample does.

Trying to override the default targets wont work. Seems like it's just get concatenated with the default ones.

Solution

Make TARGETS optional so it can be overridden while keep the default value building all architectures by default.

@DanielSRS
Copy link
Contributor Author

I am not that much familiar with make, so there is chances this is not needed at all and I just don't know how to do what I wanted 😅

@cnlohr
Copy link
Owner

cnlohr commented Nov 18, 2025

No, if you potentially want to override it that's exactly how you do it.

good job.

@cnlohr cnlohr merged commit bdf74c0 into cnlohr:master Nov 18, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants