Merged
Conversation
Owner
|
The regression test is to same |
Contributor
Author
|
Now I have O:-) . I had to add a couple of targets and also `make keystore`
in the Makefile in order to make it run on the emulator, but it does run
flawlessly as far as I can tell. Awesome :-)
Thanks again :-)
…On Thu, Oct 16, 2025 at 4:30 AM cnlohr ***@***.***> wrote:
*cnlohr* left a comment (cnlohr/rawdrawandroid#113)
<#113 (comment)>
The regression test is to same make clean run and see what happens. Have
you done that?
—
Reply to this email directly, view it on GitHub
<#113 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABVM3W4GPSVTX3W7XG5OTMD3X37LNAVCNFSM6AAAAACJJ2VUGWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZTIMBYHEZTKOJRGQ>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
Collaborator
|
It sounds to me like those changes to the makefile would be a good addition to this pull request ;) |
Contributor
Author
|
Added :-) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi, as discussed I forked the repo and updated the rawdraw link to the latest commit there. I have no idea if there are any regression tests available, but just in case here is the pull request. It is a really small change indeed.
Kind regards.