fix(sync): Improve Greenhouse kubeconfig loading and error reporting in sync command#47
Merged
onuryilmaz merged 1 commit intomainfrom Feb 18, 2026
Merged
fix(sync): Improve Greenhouse kubeconfig loading and error reporting in sync command#47onuryilmaz merged 1 commit intomainfrom
sync command#47onuryilmaz merged 1 commit intomainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR improves the robustness and clarity of the
synccommand when loading the Greenhouse cluster kubeconfig. It addresses a common issue whereclient-gowould report a cryptic "invalid configuration: no configuration has been provided" error when the default context in a kubeconfig file was missing or invalid, even if a specific context was provided via flags.Key Changes
--greenhouse-cluster-contextis specified, the tool now attempts to build the REST configuration using that context directly. This bypasses the initial attempt to load the default/current context, which was previously causing premature failures.os.Stat. This ensures a clear "file not found" error is returned instead of the generic Kubernetes configuration error.Why this is needed
Previously, the
synccommand would callclientcmd.BuildConfigFromFlags("", path)which defaults to the "current-context". If the kubeconfig existed but the current-context was empty or pointed to a non-existent entry, the command would fail immediately, preventing the user-supplied--greenhouse-cluster-contextfrom ever being used.