Make no start command test platform-aware for CF compatibility#220
Merged
tnikolova82 merged 1 commit intomasterfrom Dec 19, 2025
Merged
Make no start command test platform-aware for CF compatibility#220tnikolova82 merged 1 commit intomasterfrom
tnikolova82 merged 1 commit intomasterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make "no start command" test platform-aware for CF compatibility
What
Updates integration test to work on both Docker and CF platforms
Adds platform-specific assertions for error checking
Makes cleanup handler more robust for failed deployments
Why
The "there is no start command given" test was previously skipped on CF platform because it used Docker-specific commands (docker container logs). This prevented proper test coverage when running integration tests against Cloud Foundry environments.
Without this change:
How
Platform-specific test logic:
docker container logsto check for error message (existing behavior)cf logs --recentto validate error messageImproved cleanup:
Testing: