Skip to content

ci: fix ID token perms#142

Open
ashutosh-ukey wants to merge 1 commit intocirclefin:masterfrom
ashutosh-ukey:ci/fix-publish-1
Open

ci: fix ID token perms#142
ashutosh-ukey wants to merge 1 commit intocirclefin:masterfrom
ashutosh-ukey:ci/fix-publish-1

Conversation

@ashutosh-ukey
Copy link
Contributor

@ashutosh-ukey ashutosh-ukey commented Mar 19, 2026

Summary

Restore id-token: write in the reusable npm publish workflow so AWS OIDC auth works during publish

Why

  • the publish pipeline is failing in Configure AWS Credentials before npm publish
  • aws-actions/configure-aws-credentials is using role-to-assume, which requires a GitHub OIDC token
  • the workflow only grants contents: read, so the job cannot mint that token

Details

Regression Context

  • id-token: write was originally added in ffcaf51 (fix: allow OIDC token in publish pipeline (#25))
  • it was removed in 40ee83f (chore(stepsecurity): update workflows to use custom hosted runners with built-in StepSecurity (#133))
  • that regression stayed hidden until 27f4efe (ci: fix release-please wiring (#140)) fixed release gating and caused npm-publish to run again

Validation

  • reviewed failed run 23300901189 and failing job 67761702334
  • confirmed the job fails in Configure AWS Credentials with the log: Did you mean to set the id-token permission?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant