Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Restore
id-token: writein the reusable npm publish workflow so AWS OIDC auth works during publishWhy
Configure AWS Credentialsbeforenpm publishaws-actions/configure-aws-credentialsis usingrole-to-assume, which requires a GitHub OIDC tokencontents: read, so the job cannot mint that tokenDetails
Regression Context
id-token: writewas originally added inffcaf51(fix: allow OIDC token in publish pipeline (#25))40ee83f(chore(stepsecurity): update workflows to use custom hosted runners with built-in StepSecurity (#133))27f4efe(ci: fix release-please wiring (#140)) fixed release gating and causednpm-publishto run againValidation
23300901189and failing job67761702334Configure AWS Credentialswith the log:Did you mean to set the id-token permission?