Conversation
Adds a new static method to Rs2Player that detects whether the player is currently inside a Player Owned House (POH). Detection uses two conditions: - scene.isInstance() — true for all instanced regions - POH_HOUSE_LOCATION varbit > 0 — specific to POH Combining both avoids false positives from other instanced regions (Gauntlet, Hallowed Sepulchre, etc). Also updates docs/api/Rs2Player.md with the new method entry.
feat(Rs2Player): add isInPoh() utility method
Ths extra contentsPanel was forcing the entire panel contents to be confined into a very small area and so made the dynamic grid layout layout everything sequentially without any scaling. Use a box layout without the extra panel and set the maximum size of the added panels to their preferred size's height instead.
There are some situations where these widgets can end up being hidden, such as when logging in with a greegree equipped, which hides the player's spellbook.
There was no empty space between the section contents matte border and the config panels without a section
This reverts commit 7a36ce1.
This reverts commit da9ce70.
This reverts commit 9256ba6.
Co-authored-by: Hamish <208728510+DustyRealm@users.noreply.github.com>
Also handle index deserialization errors
[ci skip]
# Conflicts: # gradle.properties # runelite-client/src/main/java/net/runelite/client/plugins/config/ConfigPanel.java
The chatbox widget children in group 162 shifted by +1 in a recent game update. handleAmount was checking child 42 (now CHATBOX_TITLE) instead of child 43 (CHATBOX_FULL_INPUT) for the "Enter amount:" prompt, causing sleepUntil to always time out. - Updated Rs2Bank.java widget check from (162, 42) to (162, 43) - Updated stale WidgetIndices.ChatBox constants to match current RuneLite ComponentID values Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
fix: update chatbox widget IDs for Rs2Bank.withdrawX
|
Caution Review failedPull request was closed or merged during review WalkthroughThis PR introduces widespread game content and system updates across the RuneLite codebase. Changes include version bumps (1.12.18→1.12.19), chatbox widget index realignment via +1 shifts, addition of new NPC and item identifiers (including BIGREDJAPAN and RED_CRAB variants), removal of deprecated animation constants, refactoring of FontType from enum to class with dynamic font support, UI enhancements to InteractHighlight for player and ground item targeting, and corresponding updates to configuration interfaces, scripts, and widget mappings throughout the API and client layers. Possibly related PRs
🚥 Pre-merge checks | ❌ 3❌ Failed checks (1 warning, 2 inconclusive)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches
Warning There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure. 🔧 ast-grep (0.41.0)runelite-api/src/main/java/net/runelite/api/gameval/SpriteID.javarunelite-api/src/main/java/net/runelite/api/ItemID.javarunelite-api/src/main/java/net/runelite/api/NpcID.java
Tip Try Coding Plans. Let us write the prompt for your AI agent so you can ship faster (with fewer bugs). Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
8 participants
No description provided.