Skip to content

New Crowdin Translations#427

Open
chr233 wants to merge 1 commit intomasterfrom
l10n_master
Open

New Crowdin Translations#427
chr233 wants to merge 1 commit intomasterfrom
l10n_master

Conversation

@chr233
Copy link
Copy Markdown
Owner

@chr233 chr233 commented Apr 12, 2026

New Crowdin translations by Crowdin GH Action

Copilot AI review requested due to automatic review settings April 12, 2026 02:13
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the en-US localization resource with new Crowdin-provided translations, replacing previously non-English strings for several market-related messages.

Changes:

  • Updated market-related en-US resource entries (URL validation, item info labels, price labels, buy order workflow messages).
  • Replaced Chinese strings in Langs.en-US.resx with English equivalents for the affected keys.

</data>
<data name="MarketItemId" xml:space="preserve">
<value>物品Id: {0} - {1}</value>
<value>Item Id: {0} - {1}</value>
Copy link

Copilot AI Apr 12, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

MarketItemId is formatted with two IDs ({0} = AppId and {1} = ItemId), but the label only says "Item Id". This makes the output misleading; consider updating the text to explicitly name both IDs (or adjust placeholders so it truly prints only an item id).

Suggested change
<value>Item Id: {0} - {1}</value>
<value>App Id: {0} - Item Id: {1}</value>

Copilot uses AI. Check for mistakes.
</data>
<data name="MarketBuyResult" xml:space="preserve">
<value>创建求购订单{0}: {1}</value>
<value>Creating Order{0}: {1}</value>
Copy link

Copilot AI Apr 12, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

MarketBuyResult currently renders as "Creating OrderSuccess: ..."/"Creating OrderFailure: ..." because there's no separator/space before {0}. Add a delimiter (e.g., a space or punctuation) so the status placeholder formats correctly and the message is readable.

Suggested change
<value>Creating Order{0}: {1}</value>
<value>Creating Order {0}: {1}</value>

Copilot uses AI. Check for mistakes.
Comment on lines 1569 to +1573
<data name="BuyPriceInvalid" xml:space="preserve">
<value>求购价格无效</value>
<value>Invalid Purchase Price</value>
</data>
<data name="BuyAmountInvalid" xml:space="preserve">
<value>求购数量无效</value>
<value>Invalid purchase quantity</value>
Copy link

Copilot AI Apr 12, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These validation messages use inconsistent capitalization compared to other strings in this file (e.g., "Invalid entry", "Invalid parameter..."). Consider switching to sentence case for consistency (e.g., "Invalid purchase price" / "Invalid input").

Copilot uses AI. Check for mistakes.
</data>
<data name="MarketOrderListEmpty" xml:space="preserve">
<value>市场求购列表为空</value>
<value>Marketplace Purchase List is empty</value>
Copy link

Copilot AI Apr 12, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

MarketOrderListEmpty says "Marketplace Purchase List is empty" but the next label is "Purchase Order List:". Consider using consistent terminology (and sentence case) so the empty-state message matches the list title (e.g., "Purchase order list is empty").

Suggested change
<value>Marketplace Purchase List is empty</value>
<value>Purchase order list is empty</value>

Copilot uses AI. Check for mistakes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants