Conversation
There was a problem hiding this comment.
Pull request overview
Updates the en-US localization resource with new Crowdin-provided translations, replacing previously non-English strings for several market-related messages.
Changes:
- Updated market-related
en-USresource entries (URL validation, item info labels, price labels, buy order workflow messages). - Replaced Chinese strings in
Langs.en-US.resxwith English equivalents for the affected keys.
| </data> | ||
| <data name="MarketItemId" xml:space="preserve"> | ||
| <value>物品Id: {0} - {1}</value> | ||
| <value>Item Id: {0} - {1}</value> |
There was a problem hiding this comment.
MarketItemId is formatted with two IDs ({0} = AppId and {1} = ItemId), but the label only says "Item Id". This makes the output misleading; consider updating the text to explicitly name both IDs (or adjust placeholders so it truly prints only an item id).
| <value>Item Id: {0} - {1}</value> | |
| <value>App Id: {0} - Item Id: {1}</value> |
| </data> | ||
| <data name="MarketBuyResult" xml:space="preserve"> | ||
| <value>创建求购订单{0}: {1}</value> | ||
| <value>Creating Order{0}: {1}</value> |
There was a problem hiding this comment.
MarketBuyResult currently renders as "Creating OrderSuccess: ..."/"Creating OrderFailure: ..." because there's no separator/space before {0}. Add a delimiter (e.g., a space or punctuation) so the status placeholder formats correctly and the message is readable.
| <value>Creating Order{0}: {1}</value> | |
| <value>Creating Order {0}: {1}</value> |
| <data name="BuyPriceInvalid" xml:space="preserve"> | ||
| <value>求购价格无效</value> | ||
| <value>Invalid Purchase Price</value> | ||
| </data> | ||
| <data name="BuyAmountInvalid" xml:space="preserve"> | ||
| <value>求购数量无效</value> | ||
| <value>Invalid purchase quantity</value> |
There was a problem hiding this comment.
These validation messages use inconsistent capitalization compared to other strings in this file (e.g., "Invalid entry", "Invalid parameter..."). Consider switching to sentence case for consistency (e.g., "Invalid purchase price" / "Invalid input").
| </data> | ||
| <data name="MarketOrderListEmpty" xml:space="preserve"> | ||
| <value>市场求购列表为空</value> | ||
| <value>Marketplace Purchase List is empty</value> |
There was a problem hiding this comment.
MarketOrderListEmpty says "Marketplace Purchase List is empty" but the next label is "Purchase Order List:". Consider using consistent terminology (and sentence case) so the empty-state message matches the list title (e.g., "Purchase order list is empty").
| <value>Marketplace Purchase List is empty</value> | |
| <value>Purchase order list is empty</value> |
New Crowdin translations by Crowdin GH Action