Refactor chart functions + 3 new charts#149
Open
chaosfinity wants to merge 5 commits intochinmaymk:pr/137from
chaosfinity:Provider
Open
Refactor chart functions + 3 new charts#149chaosfinity wants to merge 5 commits intochinmaymk:pr/137from chaosfinity:Provider
chaosfinity wants to merge 5 commits intochinmaymk:pr/137from
chaosfinity:Provider
Conversation
added 4 commits
September 24, 2014 11:11
Rename service to acChartLogicProvider to increase semantics
Moved default colors to provider and made getter/setter functions Made tests for color getter/setter
Fix default legend function for line chart Normalize Graph type charts by offering a getGraph function
Change getGraph to include a horizontal option Add function to adjust left margin to horizontal chart labels Add function to get list of charts available Changed examples to fetch available charts and create the selectable list Rotate xAxis labels now uses positive and negative numbers the same way, to rotate away from the graph
Author
|
Added 3 new charts, bar-stacked, slab, and slab-stacked. What else needs to be done to get these updates into a release? |
Author
|
About stacked charts: |
Updated tests to accomodate new element structure for line/point charts Update width/height error to only check for that error and not any error
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Here's another big one, the diff makes my head hurt.
And the list:
getGraph() example
I'll begin working on documentation for the provider API as soon as this is decided on