Conversation
|
I will merge the image data first. I don't think the "all imports work" test is run by CI any more. We might get a failure on the DLS Jenkins job, but if you add the concrete tests soon this isn't a problem. |
|
@dagewa Thank you very much for merging test images. dials_data("image_examples") / "Hypix6000-monoclinic_lysozyme1_1_1.rodhypix.bz2"I am writing my own tests in |
|
If you have built DIALS using its own |
|
@dagewa Thanks. I added tests. In my local computer, pytest --regression tests/format/test_FormatROD.py -vpassed. However, test runs on GitHub failed to find the newly added test images. This is strange, because both PRs into
https://github.com/cctbx/dxtbx/actions/runs/22379175084/job/64775933987?pr=879#step:8:24 How do I update them? |
|
The conda-forge package updated now. We might need to force it to use that version, by setting in the files in |
|
@dagewa Thanks! Tests are running now. If nothing fails, this PR is ready to be merged. |
dagewa
left a comment
There was a problem hiding this comment.
Thanks for adding this. I tested with a TY6 data set to make sure I could still read the images properly and confirmed it was fine.
This also adds support for gzip/bzipped files, non-unity gain and binning.
This solves issue #878.
@dagewa What is the right order to add tests? Necessary images are in the following PRs:
Once test images are merged, I can add concrete tests (e.g. testing the gain). But if we merge test data before this dxtbx PR, the existing "all imports work" test will fail and block other commits.