Remove the requirement for jira in opensource#29
Open
layfield-ccdc wants to merge 4 commits intomainfrom
Open
Conversation
There was a problem hiding this comment.
Pull request overview
Removes the Jira ID requirement for “ccdc-opensource” repositories to improve the contributor experience for external PRs.
Changes:
- Added
get_repo()to detect the current repository (owner/repo) in CI and locally. - Updated
check_commit_msgto skip checks for opensource repos, and adjusted call sites/tests accordingly.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
main/githooks.py
Outdated
Comment on lines
150
to
155
| def get_repo(): | ||
| '''Get the repo name in the format of "owner/repo"''' | ||
| if _is_github_event(): | ||
| return os.environ['GITHUB_REPOSITORY'] | ||
| else: | ||
| return _get_output(['git', 'config', '--get', 'remote.origin.url']).strip().split(':')[-1].rstrip('.git') |
There was a problem hiding this comment.
New behavior is introduced in get_repo() (CI vs local parsing) but there’s no unit test coverage for it. Since this file already contains unittest coverage for commit message validation, add tests for get_repo() (at least HTTPS and SSH remote formats), and also add a focused test that verifies opensource repos bypass only the Jira requirement (and still enforce file-size rules if that’s the intended policy).
Alex-AMC
approved these changes
Feb 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Better experience for external contributors