An attempt at building a cross platform executable with dotnet#12
An attempt at building a cross platform executable with dotnet#12rockdreamer wants to merge 7 commits intomainfrom
Conversation
| # Local History for Visual Studio | ||
| .localhistory/ | ||
|
|
||
| # BeatPulse healthcheck temp database |
There was a problem hiding this comment.
This looks irrelevant, as do quite a few entries in this file. It's difficult to see what is relevant.
| <Project Sdk="Microsoft.NET.Sdk"> | ||
| <PropertyGroup> | ||
| <OutputType>Exe</OutputType> | ||
| <TargetFramework>net5.0</TargetFramework> |
There was a problem hiding this comment.
I wondered if it would be better to use Net Core rather than the full framework?
| // run CommitHookCheckInterface checks | ||
| // return 0 if everything is ok | ||
| // or 1 if something should be aborted | ||
| return 0; |
There was a problem hiding this comment.
This doesn't appear to do anything - ah - now I realise this is just a framework, not a complete implementation.
| #!/usr/bin/env bash | ||
| SCRIPT_DIR="$( cd "$( dirname "${BASH_SOURCE[0]}" )" &> /dev/null && pwd )" | ||
|
|
||
| This is currently used to decide if large file should be commited. |
There was a problem hiding this comment.
These changes look sensible, but I feel they should be removed from this PR as it makes it impossible to merge it to main as it replaces the python calls but without replacing them with a working C# version. I feel it would be better to be able to merge the C# to main independently of these changes to make them the default.
2 participants
No description provided.