-
Notifications
You must be signed in to change notification settings - Fork 0
feat:mapping start context #42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
two-Gee
wants to merge
3
commits into
main
Choose a base branch
from
feat/mapping-start-context
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,35 @@ | ||
| /* checksum : test-fixture-start-no-input */ | ||
|
|
||
| /** Test fixture: Process definition for startNoInputProcess. | ||
| * Used to test that when no @bpm.process.start.inputs annotation is defined, | ||
| * only entity fields matching ProcessInputs element names are sent. */ | ||
| @protocol : 'none' | ||
| @bpm.process : 'startNoInputProcess' | ||
| service StartNoInputProcessService { | ||
|
|
||
| type ProcessInputs { | ||
| status : String; | ||
| origin : String; | ||
| }; | ||
|
|
||
| type ProcessOutputs {}; | ||
|
|
||
| action start( | ||
| inputs : ProcessInputs not null | ||
| ); | ||
|
|
||
| action suspend( | ||
| businessKey : String not null, | ||
| cascade : Boolean | ||
| ); | ||
|
|
||
| action resume( | ||
| businessKey : String not null, | ||
| cascade : Boolean | ||
| ); | ||
|
|
||
| action cancel( | ||
| businessKey : String not null, | ||
| cascade : Boolean | ||
| ); | ||
| }; |
36 changes: 36 additions & 0 deletions
36
tests/bookshop/srv/external/startNoInputWithAssocProcess.cds
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,36 @@ | ||
| /* checksum : test-fixture-start-no-input-with-assoc */ | ||
|
|
||
| /** Test fixture: Process definition for startNoInputWithAssocProcess. | ||
| * Used to test that when no @bpm.process.start.inputs annotation is defined, | ||
| * only entity fields matching ProcessInputs element names are sent. */ | ||
| @protocol : 'none' | ||
| @bpm.process : 'startNoInputWithAssocProcess' | ||
| service StartNoInputWithAssocProcessService { | ||
|
|
||
| type ProcessInputs { | ||
| ID : UUID; | ||
| status : String; | ||
| author_ID : UUID; | ||
| }; | ||
|
|
||
| type ProcessOutputs {}; | ||
|
|
||
| action start( | ||
| inputs : ProcessInputs not null | ||
| ); | ||
|
|
||
| action suspend( | ||
| businessKey : String not null, | ||
| cascade : Boolean | ||
| ); | ||
|
|
||
| action resume( | ||
| businessKey : String not null, | ||
| cascade : Boolean | ||
| ); | ||
|
|
||
| action cancel( | ||
| businessKey : String not null, | ||
| cascade : Boolean | ||
| ); | ||
| }; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Logic Error: Non-unique
definitionIdlookup may return the wrong service'sProcessInputsgetProcessInputFieldNamesiteratescds.model.definitionsand stops at the first entry wheredef[PROCESS_PREFIX] === definitionId. The samedefinitionIdstring can be shared across multiple entities with different@bpm.process.start.idvalues (e.g.annotation-service.cdshas bothStartNoInputandStartNoInputZeroMatchannotated withid: 'startNoInputProcess'). More critically, the loop is looking for the service-level@bpm.processannotation, but two independent services could theoretically carry the same process id, or the iteration order ofdefinitionscould pick the wrong one first.Additionally, the lookup associates the service name with the definition id, then constructs
${serviceName}.ProcessInputs. If two services share a definition id, the resolution is non-deterministic and the wrongProcessInputstype may be used, leading to silently wrong column filtering.Should either enforce that definition-id uniqueness is assumed at a higher level (and add a warning when duplicates are found), or re-think the lookup so it doesn't silently use the first match when duplicates exist.
Please provide feedback on the review comment by checking the appropriate box: