spread: add external:ubuntu-core-24-64#12345
spread: add external:ubuntu-core-24-64#12345sergiocazzolato merged 1 commit intocanonical:masterfrom
Conversation
|
Needed by canonical/core-base#89 |
mvo5
left a comment
mvo5
left a comment
There was a problem hiding this comment.
Thank you, this looks fine except the one debug leftover. AFAICT we could promote this out of draft and merge, or is there a downside of doing this?
There was a problem hiding this comment.
This looks like a debug leftover
There was a problem hiding this comment.
Yes, it is still in use. I will remove it before I make it ready for review.
There was a problem hiding this comment.
I have removed it.
sergiocazzolato
left a comment
sergiocazzolato
left a comment
There was a problem hiding this comment.
just a comment about moving part of the change to snapd-testing-tools project
There was a problem hiding this comment.
Hi, this needs to be included in the snapd-testing-tools project
There was a problem hiding this comment.
There was a problem hiding this comment.
I think you just need to merge master because it is on master
valentindavid
force-pushed
the
valentindavid/external-ubuntu-core-24-64
branch
from
de7785a to
b9a79b3
Compare
valentindavid
force-pushed
the
valentindavid/external-ubuntu-core-24-64
branch
from
b9a79b3 to
2e902a8
Compare
sergiocazzolato
left a comment
sergiocazzolato
left a comment
There was a problem hiding this comment.
Hi, I left a comment about os.query is-core24
valentindavid
force-pushed
the
valentindavid/external-ubuntu-core-24-64
branch
2 times, most recently
from
fd43176 to
e8b879f
Compare
This is needed by core-base CI.
valentindavid
force-pushed
the
valentindavid/external-ubuntu-core-24-64
branch
from
e8b879f to
6d2d5c3
Compare
sergiocazzolato
left a comment
sergiocazzolato
left a comment
There was a problem hiding this comment.
Nice, thanks for this
3 participants
This is needed by core-base CI.