Skip to content

fix(PrefixedInput): update layout for better responsiveness#1332

Merged
kimanhou merged 1 commit intocanonical:mainfrom
kimanhou:WD-34689-prefixed-input-responsiveness
Mar 20, 2026
Merged

fix(PrefixedInput): update layout for better responsiveness#1332
kimanhou merged 1 commit intocanonical:mainfrom
kimanhou:WD-34689-prefixed-input-responsiveness

Conversation

@kimanhou
Copy link
Contributor

Done

  • PrefixedInput: change layout to handle better responsiveness

QA

Pinging @canonical/react-library-maintainers for a review.

Storybook

To see rendered examples of all react-components, run:

yarn start

QA in your project

from react-components run:

yarn build
npm pack

Install the resulting tarball in your project with:

yarn add <path-to-tarball>

QA steps

  • Check all stories of PrefixedInput and PrefixedIdInput.
  • I manually imported the changes in LXD UI and it fixes the responsiveness issues

Percy steps

  • No visual changes expected

Fixes

Fixes: https://warthogs.atlassian.net/browse/WD-34689

@webteam-app
Copy link

@kimanhou kimanhou force-pushed the WD-34689-prefixed-input-responsiveness branch 2 times, most recently from 14f0c1c to d51a1d2 Compare March 17, 2026 16:18
@kimanhou kimanhou force-pushed the WD-34689-prefixed-input-responsiveness branch from d51a1d2 to d1b6a52 Compare March 19, 2026 13:37
@kimanhou kimanhou marked this pull request as ready for review March 19, 2026 16:32
Copy link
Contributor

@edlerd edlerd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just one nitpick on keeping docs.

Comment on lines -20 to -23
/**
* The immutable text that appears at the beginning of the input field.
* This text is not editable by the user and visually appears inside the input.
*/
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should keep this bit of explanation. Wdyt?

Signed-off-by: Kim Anh Nguyen <4783194+kimanhou@users.noreply.github.com>
@kimanhou kimanhou force-pushed the WD-34689-prefixed-input-responsiveness branch from d1b6a52 to 44f517f Compare March 20, 2026 08:13
@kimanhou kimanhou merged commit 68e5d49 into canonical:main Mar 20, 2026
8 checks passed
@github-actions
Copy link

🎉 This PR is included in version 4.0.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants