refactor: replace MAX_FIRSTAID_REMOVE with ERemovableSpell enum (#3006)#3009
Merged
refactor: replace MAX_FIRSTAID_REMOVE with ERemovableSpell enum (#3006)#3009
Conversation
Replace the #define MAX_FIRSTAID_REMOVE 17 with an enum that gives meaningful names to each removable spell index: kRemAbstinent=0, kRemPoison=1, ..., kRemBattle=16, kMaxFirstaidRemove=17 This makes the difficulty threshold in firstaid (prob/10 > count) readable: you can see which spell corresponds to which skill level. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace the #define MAX_FIRSTAID_REMOVE 17 with an enum that gives meaningful names to each removable spell index:
kRemAbstinent=0, kRemPoison=1, ..., kRemBattle=16, kMaxFirstaidRemove=17
This makes the difficulty threshold in firstaid (prob/10 > count) readable: you can see which spell corresponds to which skill level.