fix: replace no-op set_wait(0) with zero_wait() (#2618)#3005
Merged
Conversation
set_wait(0) was silently ignored (guard: if (_ > 0)). These calls intended to clear wait state but did nothing. Replace with zero_wait() which properly resets m_wait to 0. - fight_stuff.cpp: clear attacker wait when target dies - bash.cpp: no lag on bash case 0 - slay.cpp: no lag on slay case 0 - firstaid.cpp: clear victim wait on successful first aid (was a bug: first aid never actually cleared the victim's lag) Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
set_wait(0) was silently ignored (guard: if (_ > 0)). These calls intended to clear wait state but did nothing. Replace with zero_wait() which properly resets m_wait to 0.