refactor: rename single-char variables in find_replacement (#3002)#3003
Merged
refactor: rename single-char variables in find_replacement (#3002)#3003
Conversation
Rename cryptic single-character variables to meaningful names: c -> mob, o -> obj, r -> room previous obj -> tmp_obj, previous room -> tmp_room Done in order per issue: first obj->tmp_obj, room->tmp_room, then c->mob, o->obj, r->room. Each step verified by compiler. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rename cryptic single-character variables to meaningful names in the 2400-line find_replacement() function:
c -> mob (CharData* cast from go or found by name)
o -> obj (ObjData* cast from go or found by name)
r -> room (RoomData* cast from go or found by name)
The previously separate UID-resolved obj/room variables were merged with the go-cast ones since they are never used simultaneously in the same code paths.