Skip to content

Schema val.: --recursion-limit 10000; skip over level=info messages #274

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
aothms wants to merge 1 commit into
base: development
Choose a base branch
from
Open

Schema val.: --recursion-limit 10000; skip over level=info messages #274

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion backend/apps/ifc_validation/tasks/check_programs.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,7 +89,7 @@ def is_schema_error(line):
def check_schema(context:TaskContext):
proc = run_subprocess(
task = context.task,
command = [sys.executable, "-m", "ifcopenshell.validate", "--json", "--rules", "--fields", context.file_path ]
command = [sys.executable, "-m", "ifcopenshell.validate", "--json", "--rules", "--fields", "--recursion-limit", "10000", context.file_path]
)
output = list(filter(is_schema_error, proc.stdout.split("\n")))
success = proc.returncode >= 0
Expand Down
3 changes: 3 additions & 0 deletions backend/apps/ifc_validation/tasks/processing/schema.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,9 @@ def process_schema(context:TaskContext):

for line in output:
message = json.loads(line)
if message["level"] == "info":
# This currently only happens due to caught RecursionErrors in rule executor
continue
outcome = ValidationOutcome(
severity=ValidationOutcome.OutcomeSeverity.ERROR,
outcome_code=ValidationOutcome.ValidationOutcomeCode.SCHEMA_ERROR,
Expand Down
Loading